Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEDONA-311] Refactor Inferred*Expression base class for Sedona SQL #871

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

Kontinuation
Copy link
Member

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

This PR refactored Inferred*Expression base classes to handle functions with any number of parameters <=16. Now there's only one InferredExpression base class, and we can use it to wrap functions with any number of parameters.

If there are multiple overloaded versions of the same function, we can specify which version to wrap using InferredExpression(inferrableFunction{N}(func)), where {N} is the number of parameters. Please refer to {{ST_Translate}} as an example.

How was this patch tested?

Running existing unit tests on this patch.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@Kontinuation Kontinuation marked this pull request as ready for review June 24, 2023 10:06
@Kontinuation Kontinuation changed the title [SEDONA-311] Refactor inferred expression base class for Spark SQL [SEDONA-311] Refactor Inferred*Expression base class for Spark SQL Jun 24, 2023
@Kontinuation Kontinuation changed the title [SEDONA-311] Refactor Inferred*Expression base class for Spark SQL [SEDONA-311] Refactor Inferred*Expression base class for Sedona SQL Jun 24, 2023
@jiayuasu jiayuasu added this to the sedona-1.5.0 milestone Jun 25, 2023
Copy link
Member

@jiayuasu jiayuasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@jiayuasu jiayuasu merged commit debac33 into apache:master Jun 25, 2023
@Kontinuation
Copy link
Member Author

Kontinuation commented Jun 25, 2023

I have to address some conflicts with the newly merged ST_Dimension patch. I've submitted another patch to fix this: #872

@Kontinuation Kontinuation deleted the refactor-inferred-expr branch August 23, 2023 15:13
Kontinuation added a commit to Kontinuation/sedona that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants