Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCB-2689] fix rate limiting configuration changed cause NPE problem #3349

Merged
merged 1 commit into from
Sep 20, 2022
Merged

[SCB-2689] fix rate limiting configuration changed cause NPE problem #3349

merged 1 commit into from
Sep 20, 2022

Conversation

liubao68
Copy link
Contributor

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install -Pit to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@liubao68 liubao68 changed the title [SCB-2686]fix date time from edge not parsed by highway problem [SCB-2689] fix rate limiting configuration changed cause NPE problem Sep 20, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3349 (cca29c1) into master (618f4b7) will decrease coverage by 0.00%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #3349      +/-   ##
============================================
- Coverage     77.60%   77.59%   -0.01%     
  Complexity     1452     1452              
============================================
  Files          1648     1648              
  Lines         43720    43718       -2     
  Branches       3679     3678       -1     
============================================
- Hits          33928    33925       -3     
- Misses         8261     8262       +1     
  Partials       1531     1531              
Impacted Files Coverage Δ
...g/apache/servicecomb/qps/QpsControllerManager.java 78.78% <81.81%> (-0.16%) ⬇️
...servicecomb/qps/ProviderQpsFlowControlHandler.java 87.50% <100.00%> (-0.74%) ⬇️
...in/java/org/apache/servicecomb/core/SCBEngine.java 79.28% <0.00%> (-1.20%) ⬇️
...mb/config/ConfigCenterConfigurationSourceImpl.java 10.63% <0.00%> (+1.06%) ⬆️
...ache/servicecomb/foundation/common/net/IpPort.java 86.66% <0.00%> (+3.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@liubao68 liubao68 merged commit 5804e9b into apache:master Sep 20, 2022
lbc97 pushed a commit to lbc97/servicecomb-java-chassis that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants