[feat] support refresh the config of syncer without redeploy servicec… #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tornado-ssy
force-pushed
the
dev-peerEndpointRefrFix
branch
from
2c0e952
to
fdb382c
Compare
little-cui
requested changes
Apr 13, 2024
syncer/config/config.go
Outdated
| @@ -68,6 +69,20 @@ func Reload() error { | |||
| return nil | |||
| } | |||
|
|
|||
| func ReloadConfig() { | |||
syncer/config/config.go
Outdated
| peer.Kind = val["kind"].(string) | ||
| peer.Endpoints = val["endpoints"].([]string) | ||
| peer.Mode = val["mode"].([]string) | ||
| config.Sync.Peers = append(config.Sync.Peers, peer) |
tornado-ssy
force-pushed
the
dev-peerEndpointRefrFix
branch
from
fdb382c
to
83df60f
Compare
tornado-ssy
force-pushed
the
dev-peerEndpointRefrFix
branch
from
83df60f
to
6e99573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…omb-center
Follow this checklist to help us incorporate your contribution quickly and easily:
[SCB-XXX] Fixes bug in ApproximateQuantiles, where you replaceSCB-XXXwith the appropriate JIRA issue.go buildgo testgo fmtgo vetto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.