Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance ip 匹配 #2227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

McdullFei
Copy link

Fixes #2226

针对次bug做的一次fix
#2226

@TeslaCN
Copy link
Member

TeslaCN commented Jun 1, 2023

Could you add unit tests for your changes?

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you change the commit content to English? This will help others search.

Copy link
Member

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Do you still have time to update the current PR? Maybe allow another person to raise a new PR fixing the current one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants