fix: Tracing is incompatible with Spring Boot 3.2.x #2401 #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
- The PR did not pass the code formatting validation. You can execute first
./mvnw spotless:apply -Pcheck -T1C. Then execute./mvnw checkstyle:check -Pcheck -T1Cto manually adjust to repair the CI. - I just opened Migrate the JDK used by CI from Temurin to Zulu #2406 to try to fix CI on master branch, you may need to wait for a while. Here are the changes for MacOS devices from Github Action.
There was a problem hiding this comment.
- You can fix checkstyle by rebasing the master branch, and CI will fix it.
- No unit tests are needed for Spring Boot 3. Going forward, ElasticJob will still have to stay on JDK8 unless ShardingSphere changes the minimum JDK runtime version. All unit tests assume Spring Boot 2.
jaychoww
force-pushed
the
fix-incompatible-issue-with-springboot-3.2+
branch
from
27af62d to
8612151
Compare
linghengqian
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
- LGTM!
- For the issue where the scope of some old versions of spring.io dependencies is changed from provided and test to compile, additional processing is done in Provides built-in GraalVM Reachability Metadata and nativeTest on Elasticjob Bootstrap #2268 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2401.
Changes proposed in this pull request:
I have tested this patch in Spring Boot 3.2.2 and it works, but I'm sorry that I can't write any test cases in the project because the test framework is based on Spring Boot 2, this issue is only effect Spring Boot 3.2+