Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(pitr): fix test case show no record #297

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

Xu-Wentao
Copy link
Collaborator

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

fix a test case bug, set 2 variables CSN and RecordID to "" to make sure the test to run as expected.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #297 (fbdd2ad) into main (46be6a7) will decrease coverage by 13.31%.
The diff coverage is 49.06%.

@@             Coverage Diff             @@
##             main     #297       +/-   ##
===========================================
- Coverage   62.36%   49.06%   -13.31%     
===========================================
  Files           2        8        +6     
  Lines         279      856      +577     
===========================================
+ Hits          174      420      +246     
- Misses        103      368      +265     
- Partials        2       68       +66     
Impacted Files Coverage Δ
pitr/cli/internal/pkg/shardingsphere-proxy.go 0.00% <0.00%> (ø)
pitr/cli/internal/pkg/local-storage.go 42.73% <42.73%> (ø)
pitr/cli/internal/cmd/restore.go 44.58% <44.58%> (ø)
pitr/cli/internal/cmd/show.go 56.09% <56.09%> (ø)
pitr/cli/internal/cmd/backup.go 58.87% <58.87%> (ø)
pitr/cli/internal/pkg/agent-server.go 72.54% <72.54%> (ø)
pitr/cli/pkg/gsutil/conn.go 76.47% <76.47%> (ø)
pitr/cli/pkg/stringutil/rand_string.go 91.30% <91.30%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Xu-Wentao Xu-Wentao force-pushed the bugfix branch 4 times, most recently from b11b96f to f5b0e69 Compare April 7, 2023 02:40
@mlycore mlycore added type: refactor pitr solutions of pitr labels Apr 7, 2023
@mlycore mlycore merged commit fdc99fd into apache:main Apr 7, 2023
@mlycore
Copy link
Contributor

mlycore commented Apr 7, 2023

LGTM

mlycore added a commit that referenced this pull request Apr 13, 2023
* bugfix(pitr): fix storage nodes info struct error, add endtime to backup file, and fix backup mode ptrack did not work. (#288)

* chore(ci): add golangci-lint and refactor according to the result (#294)

* chore: add golangci-lint check config and update Makefile for check

* fix: fix according to golangci-lint

* fix: rename Api to API

* fix: fix sharedVolumeAndMountBuild SetVolumeMountSize non-zero slice

* fix: remove overlapped Build method from shardingSphereProxyContainerBuilder

* chore: add license header

* chore(ci): add golangci-lint (#295)

* chore(ci): add golangci-lint to github action

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): seperate unit tests

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): add golangci-lint for pitr

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): fix license header

Signed-off-by: mlycore <maxwell92@126.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>

* refactor(operator): refactor according to golangci-lint (#296)

* chore: seperate golangci-lint to base and advanced lints

Signed-off-by: mlycore <maxwell92@126.com>

* fix: introduce CondSucceed to Proxy and ComputeNode status

Signed-off-by: mlycore <maxwell92@126.com>

* chore: fix according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: refactor according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: remove loggercheck

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix unit test

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): seperate golint to operator and pitr

Signed-off-by: mlycore <maxwell92@126.com>

* chore: add lint for commit message

Signed-off-by: mlycore <maxwell92@126.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix proxy controller according to golangci-lint (#299)

* chore: update golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: fix according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor update service with computenode

Signed-off-by: mlycore <maxwell92@126.com>

* fix: update service

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor proxy controller reconcile hpa, deployment and configmap according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update commit-msg action

Signed-off-by: mlycore <maxwell92@126.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update varnamelen default to 1

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix updateSSProxyContainer

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor getReadyProxyInstances

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor getReadyNodes

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix NewDeployment and set agent

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* bugfix(pitr): fix test case show no record (#297)

* test(pitr): fix test case show no record

* style: lint code

* feat: Implements EncryptionRule DistSQL Parser Visitor with AST (#301)

* feat: implements encrypt rule distsql visitor interface with ast

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* feat: add TODO

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* chore: fix import package error

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* chore: fix ci error

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* chore: fix lint

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* feat: add encrypt distsql ast

Signed-off-by: wangbo <wangbo@sphere-ex.com>

---------

Signed-off-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: wangbo <wangbo@sphere-ex.com>

* chore: add ifExists to ast (#304)

Signed-off-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: wangbo <wangbo@sphere-ex.com>

* Common builder (#305)

* refactor container builder to pkg/common

* fix golang-lint check

* add lincense check

---------

Co-authored-by: moonman <agoiyanzsa@163.com>

* refactor configmap to common pkg (#306)

Co-authored-by: moonman <agoiyanzsa@163.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: liyao <maxwell92@126.com>
Co-authored-by: Zhengqiang Duan <duanzhengqiang@apache.org>
Co-authored-by: Jack <875818649@qq.com>
Co-authored-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: moomman <85389467+moomman@users.noreply.github.com>
Co-authored-by: moonman <agoiyanzsa@163.com>
Xu-Wentao added a commit to Xu-Wentao/shardingsphere-on-cloud that referenced this pull request May 5, 2023
* bugfix(pitr): fix storage nodes info struct error, add endtime to backup file, and fix backup mode ptrack did not work. (apache#288)

* chore(ci): add golangci-lint and refactor according to the result (apache#294)

* chore: add golangci-lint check config and update Makefile for check

* fix: fix according to golangci-lint

* fix: rename Api to API

* fix: fix sharedVolumeAndMountBuild SetVolumeMountSize non-zero slice

* fix: remove overlapped Build method from shardingSphereProxyContainerBuilder

* chore: add license header

* chore(ci): add golangci-lint (apache#295)

* chore(ci): add golangci-lint to github action

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): seperate unit tests

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): add golangci-lint for pitr

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): fix license header

Signed-off-by: mlycore <maxwell92@126.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>

* refactor(operator): refactor according to golangci-lint (apache#296)

* chore: seperate golangci-lint to base and advanced lints

Signed-off-by: mlycore <maxwell92@126.com>

* fix: introduce CondSucceed to Proxy and ComputeNode status

Signed-off-by: mlycore <maxwell92@126.com>

* chore: fix according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: refactor according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: remove loggercheck

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix unit test

Signed-off-by: mlycore <maxwell92@126.com>

* chore(ci): seperate golint to operator and pitr

Signed-off-by: mlycore <maxwell92@126.com>

* chore: add lint for commit message

Signed-off-by: mlycore <maxwell92@126.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix proxy controller according to golangci-lint (apache#299)

* chore: update golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: fix according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor update service with computenode

Signed-off-by: mlycore <maxwell92@126.com>

* fix: update service

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor proxy controller reconcile hpa, deployment and configmap according to golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update commit-msg action

Signed-off-by: mlycore <maxwell92@126.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update varnamelen default to 1

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix updateSSProxyContainer

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor getReadyProxyInstances

Signed-off-by: mlycore <maxwell92@126.com>

* refactor: refactor getReadyNodes

Signed-off-by: mlycore <maxwell92@126.com>

* fix: fix NewDeployment and set agent

Signed-off-by: mlycore <maxwell92@126.com>

* chore: update golangci-lint

Signed-off-by: mlycore <maxwell92@126.com>

* bugfix(pitr): fix test case show no record (apache#297)

* test(pitr): fix test case show no record

* style: lint code

* feat: Implements EncryptionRule DistSQL Parser Visitor with AST (apache#301)

* feat: implements encrypt rule distsql visitor interface with ast

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* feat: add TODO

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* chore: fix import package error

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* chore: fix ci error

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* chore: fix lint

Signed-off-by: wangbo <wangbo@sphere-ex.com>

* feat: add encrypt distsql ast

Signed-off-by: wangbo <wangbo@sphere-ex.com>

---------

Signed-off-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: wangbo <wangbo@sphere-ex.com>

* chore: add ifExists to ast (apache#304)

Signed-off-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: wangbo <wangbo@sphere-ex.com>

* Common builder (apache#305)

* refactor container builder to pkg/common

* fix golang-lint check

* add lincense check

---------

Co-authored-by: moonman <agoiyanzsa@163.com>

* refactor configmap to common pkg (apache#306)

Co-authored-by: moonman <agoiyanzsa@163.com>

---------

Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: liyao <maxwell92@126.com>
Co-authored-by: Zhengqiang Duan <duanzhengqiang@apache.org>
Co-authored-by: Jack <875818649@qq.com>
Co-authored-by: wangbo <wangbo@sphere-ex.com>
Co-authored-by: moomman <85389467+moomman@users.noreply.github.com>
Co-authored-by: moonman <agoiyanzsa@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pitr solutions of pitr type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants