Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Update ComputeNode conditions #379

Merged
merged 9 commits into from
May 28, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented May 28, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

mlycore added 8 commits May 28, 2023 16:20
Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: mlycore <maxwell92@126.com>
Signed-off-by: mlycore <maxwell92@126.com>
@github-actions github-actions bot added the operator solutions of operator label May 28, 2023
@mlycore mlycore added this to the 0.3.0 milestone May 28, 2023
@mlycore mlycore added type: enhancement New feature or request in: computenode modules of computenode labels May 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #379 (9ad041b) into main (cd25639) will increase coverage by 0.44%.
The diff coverage is 31.08%.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   48.52%   48.96%   +0.44%     
==========================================
  Files          46       47       +1     
  Lines        5053     5085      +32     
==========================================
+ Hits         2452     2490      +38     
+ Misses       2383     2371      -12     
- Partials      218      224       +6     
Impacted Files Coverage Δ
...perator/pkg/controllers/compute_node_controller.go 0.00% <0.00%> (ø)
...rator/pkg/reconcile/storagenode/aws/rdsinstance.go 22.14% <0.00%> (ø)
...operator/pkg/reconcile/computenode/compute_node.go 37.77% <37.77%> (ø)
...perator/pkg/controllers/storage_node_controller.go 55.45% <50.00%> (+0.20%) ⬆️
...here-operator/pkg/shardingsphere/shardingsphere.go 48.93% <62.50%> (-2.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: mlycore <maxwell92@126.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yx9o yx9o merged commit 4a5abbb into apache:main May 28, 2023
@mlycore mlycore deleted the feat-cn-conditions branch May 30, 2023 01:20
@mlycore
Copy link
Contributor Author

mlycore commented Jul 11, 2023

#166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: computenode modules of computenode operator solutions of operator type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants