Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does shardingsphere support clickhosue? #28892

Closed
niushaoda opened this issue Oct 30, 2023 · 7 comments · Fixed by #29297
Closed

Does shardingsphere support clickhosue? #28892

niushaoda opened this issue Oct 30, 2023 · 7 comments · Fixed by #29297

Comments

@niushaoda
Copy link

Does shardingsphere support clickhosue?

@niushaoda
Copy link
Author

niushaoda commented Oct 30, 2023

Caused by: java.lang.UnsupportedOperationException: Unsupported database from url: 'jdbc:clickhouse:

@linghengqian
Copy link
Member

  • Can you create a git containing minimal reproducible unit tests using testcontainers including clickhouse? The unit tests never tested clickhouse, but the related testcontainers url.

@Afsalmc
Copy link

Afsalmc commented Nov 13, 2023

Same experience with Vertica DB. If It has a jdbc driver the support should be there cause shardingsphere jdbc supports jdbc standard right?

@linghengqian
Copy link
Member

Same experience with Vertica DB. If It has a jdbc driver the support should be there cause shardingsphere jdbc supports jdbc standard right?

  • That's right, as long as a JDBC driver exists, the corresponding data source can be included in ShardingSphere's metadata.

  • @Afsalmc Can you provide a git containing unit tests using testcontainers? I need to know exactly what class is causing this type of problem.

@linghengqian
Copy link
Member

@linghengqian
Copy link
Member

  • @Afsalmc I added the description of databases without community LICENSE such as Vertica DB via javadoc in Convert DatabaseTypes for Clickhouse and common testcontainers #29297. In general, you need to implement the Vertica DB dialect yourself, and before implementing it you can manually port it to a known SQL dialect implementation, such as MySQL or SQL92.
  • @niushaoda Clickhouse is now parsed through the MySQL dialect, but in order to get rid of the MySQL dialect, the relevant sub-modules of clickhouse need to do more SPI implementation, which requires someone to know the specific content of the Clickhouse dialect.

@linghengqian
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment