Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert DatabaseTypes for Clickhouse and common testcontainers #29297

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Dec 5, 2023

Fixes #28892.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review December 5, 2023 13:14
@linghengqian linghengqian changed the title Convert DataTypes for Vertica, Clickhouse and common testcontainers Convert DatabaseTypes for Vertica, Clickhouse and common testcontainers Dec 5, 2023
@linghengqian linghengqian marked this pull request as draft December 5, 2023 16:44
@linghengqian linghengqian force-pushed the new-fix-28892 branch 3 times, most recently from 9a838ab to 0522f0a Compare December 6, 2023 07:02
@linghengqian linghengqian changed the title Convert DatabaseTypes for Vertica, Clickhouse and common testcontainers Convert DatabaseTypes for Clickhouse and common testcontainers Dec 6, 2023
@linghengqian linghengqian force-pushed the new-fix-28892 branch 2 times, most recently from fdda62f to 2804229 Compare December 6, 2023 07:19
@linghengqian linghengqian marked this pull request as ready for review December 6, 2023 07:49
@terrymanu terrymanu merged commit 1ca8a9d into apache:master Dec 7, 2023
133 checks passed
@terrymanu terrymanu added this to the 5.4.2 milestone Dec 7, 2023
@linghengqian linghengqian deleted the new-fix-28892 branch December 7, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does shardingsphere support clickhosue?
2 participants