Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update identifier defition in MySQL BaseRule.g4 file according to MySQL 8.4 doc #33719

Closed
strongduanmu opened this issue Nov 19, 2024 · 2 comments · Fixed by #33846
Closed

Update identifier defition in MySQL BaseRule.g4 file according to MySQL 8.4 doc #33719

strongduanmu opened this issue Nov 19, 2024 · 2 comments · Fixed by #33846

Comments

@strongduanmu
Copy link
Member

strongduanmu commented Nov 19, 2024

Feature Request

Is your feature request related to a problem?

No

Describe the feature you would like.

With the release of MySQL 8.4, ShardingSphere needs to update the identifier rules in BaseRule.g4 to adapt to MySQL non-reserved keywords, which can be used directly as identifiers without quotes.

Of course, I found that the non-reserved keywords before 8.4 were not fully added to the g4 file, such as zone, so this is a good opportunity to update the identifier. Let's make it more perfect together.

For MySQL non-reserved keywords, you can refer to: https://dev.mysql.com/doc/refman/8.4/en/keywords.html#keywords-in-current-series

@strongduanmu strongduanmu changed the title Update identifier defition in MySQL Update identifier defition in MySQL BaseRule.g4 file according to MySQL 8.4 doc Nov 19, 2024
@Yash-cor
Copy link
Contributor

Yash-cor commented Dec 1, 2024

Hello @strongduanmu I have made the changes to the PR - #33846

@strongduanmu strongduanmu added this to the 5.5.2 milestone Dec 1, 2024
@strongduanmu
Copy link
Member Author

Hello @strongduanmu I have made the changes to the PR - #33846

Good job, I will review this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment