Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 33719 Adding non-reserved keywords in MySQL BaseRule.g4 grammar file according to MySQL 8.4 doc #33846

Merged

Conversation

Yash-cor
Copy link
Contributor

@Yash-cor Yash-cor commented Nov 30, 2024

Fixes #33719 Changes proposed in this pull request:

Made Changes in BaseRule.g4 file and added the keywords according to MySQL 8.4 doc
Changes Include -

  • AUTHENTICATION
  • AUTO
  • BERNOULLI
  • BINLOGBIT
  • BULK
  • CHALLENGE_RESPONSECHANGED
  • FINISH
  • GTIDS
  • INITIAL
  • KILL
  • KEYRING
  • LOOP
  • MANUAL
  • MATCH
  • MAXVALUE
  • MIN_ROWS
  • MODIFIES
  • NATURAL
  • OF
  • PARSE_TREE
  • QUALIFY
  • REGISTRATION
  • S3
  • URL

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.
  • I have updated the Release Notes of the current development version. For more details, see Update Release Note

@Yash-cor Yash-cor changed the title Issue 33719 mysql baserule update Issue 33719 MySQL BaseRule.g4 Update Nov 30, 2024
@strongduanmu
Copy link
Member

Hi @Yash-cor, can you comment on the origianl issue? I will assign it to you.

@strongduanmu
Copy link
Member

Hi @Yash-cor, can you update pr title for better understanding? In addition, you need to update this PR to the RELEASE NOTE of 5.5.2-SNAPSHOT.

@Yash-cor Yash-cor changed the title Issue 33719 MySQL BaseRule.g4 Update Issue 33719 Adding non-reserved keywords in MySQL BaseRule.g4 grammar file according to MySQL 8.4 doc Dec 1, 2024
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, merged. @Yash-cor Thank you for your contribution.

@strongduanmu strongduanmu merged commit ccc8429 into apache:master Dec 1, 2024
147 checks passed
@Yash-cor Yash-cor deleted the ISSUE_33719_MYSQL_BASERULE_UPDATE branch December 2, 2024 04:56
@Yash-cor Yash-cor restored the ISSUE_33719_MYSQL_BASERULE_UPDATE branch December 2, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update identifier defition in MySQL BaseRule.g4 file according to MySQL 8.4 doc
2 participants