Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve placeholder in datasource configuration #1020

Merged

Conversation

errordaiwa
Copy link
Contributor

Fixes #1011 .

Changes proposed in this pull request:

  • fix an issue where placeholder like ${} in datasource configuration can't be resolved
  • add integration test case for placeholder resolving

@codecov-io
Copy link

Codecov Report

Merging #1020 into dev will increase coverage by 0.04%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1020      +/-   ##
==========================================
+ Coverage   54.93%   54.98%   +0.04%     
==========================================
  Files         630      630              
  Lines       12325    12349      +24     
  Branches     1972     1976       +4     
==========================================
+ Hits         6771     6790      +19     
- Misses       5142     5144       +2     
- Partials      412      415       +3
Impacted Files Coverage Δ
...c/orchestration/spring/boot/util/PropertyUtil.java 53.84% <92.3%> (+16.8%) ⬆️
...dingsphere/jdbc/spring/boot/util/PropertyUtil.java 53.84% <92.3%> (+16.8%) ⬆️
...ngsphere/opentracing/sampling/SamplingService.java 88% <0%> (-12%) ⬇️
...OrchestrationMasterSlaveDataSourceFactoryBean.java 66.66% <0%> (-11.12%) ⬇️
.../internal/config/ConfigurationListenerManager.java 56.75% <0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e42a9a...44060da. Read the comment docs.

@terrymanu terrymanu merged commit 9f23ee1 into apache:dev Jul 17, 2018
@terrymanu
Copy link
Member

thank you for contribute code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve placeholder in Spring Boot YAML configuration
3 participants