Compatible with spring boot 2.x

[SirMin]

Fixes #13602.

Changes proposed in this pull request:

1. springboot2.x config key toDashed

[TeslaCN]

LICENSE in shardingsphere-distribution should also be updated if versions of dependencies changed.

[codecov-commenter]

Codecov Report

Merging #14729 (05c45b2) into master (1aacef7) will increase coverage by 0.02%.
The diff coverage is 44.44%.

@@             Coverage Diff              @@
##             master   #14729      +/-   ##
============================================
+ Coverage     60.49%   60.51%   +0.02%     
  Complexity     1954     1954              
============================================
  Files          3220     3220              
  Lines         48269    48284      +15     
  Branches       8248     8254       +6     
============================================
+ Hits          29200    29219      +19     
+ Misses        16691    16673      -18     
- Partials       2378     2392      +14     

Impacted Files	Coverage Δ
.../shardingsphere/spring/boot/util/PropertyUtil.java	50.00% <44.44%> (-1.12%)	⬇️
...d/text/distsql/ral/common/hint/HintSourceType.java	0.00% <0.00%> (-42.86%)	⬇️
...protocol/PostgreSQLNumericBinaryProtocolValue.java	71.42% <0.00%> (-6.35%)	⬇️
...xtended/bind/protocol/PostgreSQLByteConverter.java	51.98% <0.00%> (+7.04%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aacef7...05c45b2. Read the comment docs.

[SirMin]

LICENSE in shardingsphere-distribution should also be updated if versions of dependencies changed.

already update

[SirMin]

update LICENSE

[TeslaCN]

@ZjcNB Please help check this PR.

[zhaojinchao95]

@ZjcNB Please help check this PR.

Thx, I will check it.

[zhaojinchao95]

@SirMin Hello, Can you pull and merge master branch?

[SirMin]

@ZjcNB

@SirMin Hello, Can you pull and merge master branch?

done

[zhaojinchao95]

1. upgrade snakeyaml 1.16 -> 1.29
2. Expand the release coverage of Springframework
3. Expand the release coverage of Spring boot
4. Modifying unit tests

Fixes #13602.

Changes proposed in this pull request:

• upgrade snakeyaml 1.16 -> 1.29
• Expand the release coverage of Springframework
• Expand the release coverage of Spring boot
• Modifying unit tests

@SirMin Hi, thank for your submit this pull request, this idea likes good. But i hava a question.

First, Springboot 2.x not support use _ , it 's only support -, i think this Springboot problem. ShardingSphere maybe needn't to compatible it. I think throws exception is better.

[SirMin]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support.
code in pr is from spring.

org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm.
the springboot version is 2.3.4.RELEASE

[zhaojinchao95]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.

org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

[SirMin]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.
org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

@ZjcNB spring boot 2.x not support snakeyaml 1.16. need to uppgrade

[zhaojinchao95]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.
org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

@ZjcNB spring boot 2.x not support snakeyaml 1.16. need to uppgrade

I think add toDashedForm() to resolve your problem, springboot version maybe shouldn't upgradle.

[SirMin]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.
org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

@ZjcNB spring boot 2.x not support snakeyaml 1.16. need to uppgrade

I think add toDashedForm() to resolve your problem, springboot version maybe shouldn't upgradle.

Does the unit test not cover the springboot 2.x version? if not covert I will rollback it.

[zhaojinchao95]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.
org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

@ZjcNB spring boot 2.x not support snakeyaml 1.16. need to uppgrade

I think add toDashedForm() to resolve your problem, springboot version maybe shouldn't upgradle.

Does the unit test not cover the springboot 2.x version? if not covert I will rollback it.

Yeah, Please rollback about springboot upgradle. only keep toDashedForm().

[SirMin]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.
org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

@ZjcNB spring boot 2.x not support snakeyaml 1.16. need to uppgrade

I think add toDashedForm() to resolve your problem, springboot version maybe shouldn't upgradle.

Does the unit test not cover the springboot 2.x version? if not covert I will rollback it.

Yeah, Please rollback about springboot upgradle. only keep toDashedForm().

done

[zhaojinchao95]

Thanks. i will check it again.

[linghengqian]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.
org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

@ZjcNB spring boot 2.x not support snakeyaml 1.16. need to uppgrade

Does this have much to do with the snakeyaml.version ? I want to know whether the generic lost it with #15260 .

[SirMin]

@ZjcNB springboot only @ConfigurationProperties not support '_', but @value support. code in pr is from spring.
org.springframework.boot.context.properties.bind.DataObjectPropertyName#toDashedForm. the springboot version is 2.3.4.RELEASE

Yes, i see. By the way, i think add toDashedForm() for PropertyUtil.class, it's ok. But why change dependency.

@ZjcNB spring boot 2.x not support snakeyaml 1.16. need to uppgrade

Does this have much to do with the snakeyaml.version ? I want to know whether the generic lost it with #15260 .

@linghengqian yes, SET type generic lost in new snakeyaml. can use list instead of it, or set type

[zhaojinchao95]

@SirMin This pull request has some conflicts, Can you resolve it?

[SirMin]

@SirMin This pull request has some conflicts, Can you resolve it?

@ZjcNB done!

1. Modify the private to default for unit testing
2. add JUnit test

[linghengqian]

Does this have much to do with the snakeyaml.version ? I want to know whether the generic lost it with #15260 .

@linghengqian yes, SET type generic lost in new snakeyaml. can use list instead of it, or set type

I did not reply to you at the first time because I was busy. This is actually a bug introduced since snakeyaml 1.19 . Reference in https://bitbucket.org/snakeyaml/snakeyaml/issues/387/support-for-generic-types-when-serializing .