Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache Calcite to 1.30.0 to improve GraalVM support #19737

Merged
merged 5 commits into from
Aug 1, 2022

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Aug 1, 2022

Fixes #19735.

Changes proposed in this pull request:

  • update pom.xml .
  • update LICENSE.
  • Handle deprecated methods and deprecated classes in the following classes.
    • org.apache.shardingsphere.infra.federation.optimizer.converter.segment.expression.impl.InExpressionConverter
    • org.apache.shardingsphere.infra.federation.optimizer.converter.segment.projection.impl.AggregationProjectionConverter
    • etc.

…rter.segment.expression.impl.InExpressionConverter` and `org.apache.shardingsphere.infra.federation.optimizer.converter.segment.projection.impl.AggregationProjectionConverter`, in Deprecated methods and deprecated classes of .
…erter.segment.expression.impl.FunctionConverter#getSqlNodes`.
@linghengqian
Copy link
Member Author

The deprecated method call of org.apache.shardingsphere.infra.federation.optimizer.context.planner.OptimizerPlannerContextFactory#createValidator involves some extra logic, so I didn't deal with that. Because I think before Apache Calcite 2.0, that One method could be improved. Maybe.

@linghengqian linghengqian marked this pull request as ready for review August 1, 2022 06:39
@strongduanmu strongduanmu added this to the 5.1.3 milestone Aug 1, 2022
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@strongduanmu strongduanmu merged commit 99392dc into apache:master Aug 1, 2022
@linghengqian linghengqian deleted the calcite-core-update branch August 1, 2022 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update org.apache.calcite:calcite-core to 1.28.0 or newer to improve GraalVM support
2 participants