Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor YamlLoggingRuleConfigurationSwapper #24729

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Refactor YamlLoggingRuleConfigurationSwapper #24729

merged 1 commit into from
Mar 22, 2023

Conversation

zhfeng
Copy link
Contributor

@zhfeng zhfeng commented Mar 22, 2023

Fixes #24728.

Changes proposed in this pull request:

  • refactor YamlLoggingRuleConfigurationSwapper

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@RaigorJiang RaigorJiang added this to the 5.3.3 milestone Mar 22, 2023
@RaigorJiang RaigorJiang merged commit 5d9b43d into apache:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaigorJiang RaigorJiang RaigorJiang approved these changes

Assignees

@zhfeng zhfeng

Labels
feature: logging type: refactor
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

Refactor YamlLoggingRuleConfigurationSwapper to add getDefaultLoggingRuleConfiguration
2 participants
@zhfeng @RaigorJiang