Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Atomikos to 6.0.0 on javax classifier #27549

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Jul 28, 2023

For #26041, #26275 and #26274.

Changes proposed in this pull request:

  • Update Atomikos to 6.0.0 on javax classifier.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian added feature: transaction type: dependencies Pull requests that update a dependency file labels Jul 28, 2023
@linghengqian linghengqian marked this pull request as ready for review July 28, 2023 16:07
Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • @zhaojinchao95 Hi, I retested the Atomikos 6.0.0 related branch on Microsoft OpenJDK 11.0.20. I didn't find a compilation error at ./mvnw clean install -Prelease -T1C -DskipTests -Djacoco.skip=true -Dcheckstyle.skip=true -Drat.skip=true -Dmaven.javadoc.skip=true -B.

  • Have you had time to share the java --version output of the JDK that compiled incorrectly?

  • image

@zhaojinchao95
Copy link
Contributor

  • @zhaojinchao95 Hi, I retested the Atomikos 6.0.0 related branch on Microsoft OpenJDK 11.0.20. I didn't find a compilation error at ./mvnw clean install -Prelease -T1C -DskipTests -Djacoco.skip=true -Dcheckstyle.skip=true -Drat.skip=true -Dmaven.javadoc.skip=true -B.
  • Have you had time to share the java --version output of the JDK that compiled incorrectly?
  • image

openjdk 11.0.18 2023-01-17
OpenJDK Runtime Environment Temurin-11.0.18+10 (build 11.0.18+10)
OpenJDK 64-Bit Server VM Temurin-11.0.18+10 (build 11.0.18+10, mixed mode)

@linghengqian
Copy link
Member Author

  • @zhaojinchao95 I retested 11.0.18-tem under Ubuntu 22.04 LTS and still no compilation errors. Do you have time to help re-review?
sudo apt install unzip zip curl sed -y
curl -s "https://get.sdkman.io" | bash
source "$HOME/.sdkman/bin/sdkman-init.sh"
sdk install java 11.0.18-tem

sdk use java 11.0.18-tem
git clone git@github.com:linghengqian/shardingsphere.git -b update-atomikos
cd ./shardingsphere/
./mvnw clean install -Prelease -T1C -DskipTests -Djacoco.skip=true -Dcheckstyle.skip=true -Drat.skip=true -Dmaven.javadoc.skip=true -B
./mvnw clean install -Prelease -T1C
  • image

@zhaojinchao95 zhaojinchao95 merged commit 84ccc0b into apache:master Jul 30, 2023
@linghengqian linghengqian deleted the update-atomikos branch July 30, 2023 01:35
@linghengqian linghengqian added this to the 5.4.1 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: transaction type: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants