Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare in the document that ReadWriteSplitting Config is parsed by GroovyShell by default and adds corresponding unit tests #29034

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Nov 14, 2023

For #29000.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

…roovyShell by default and adds corresponding unit tests
@mlycore mlycore merged commit c97b7f9 into apache:master Nov 14, 2023
15 checks passed
@linghengqian linghengqian deleted the fix-doc-read-write branch November 14, 2023 11:05
@linghengqian linghengqian added this to the 5.4.2 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants