Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates documentation for using Java Agent when building ShardingSphere Proxy Native #29625

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Updates documentation for using Java Agent when building ShardingSphere Proxy Native #29625

merged 1 commit into from
Jan 2, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Jan 2, 2024 •
edited
Loading

For #29052.

Changes proposed in this pull request:

  • Updates documentation for using Java Agent when building ShardingSphere Proxy Native.
  • To make a long story short, Support Java agent instrumentation in native image oracle/graal#8077 gives a solution to use OpenTelemetry Java Agent when building GraalVM Native Image, which requires the introduction of new GraalVM SDK related APIs. This means that the previous section of ShardingSphere Proxy Native on using Java Agent is outdated.
  • This PR also adds to the documentation some phenomena that are only verifiable in unit tests.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian marked this pull request as ready for review January 2, 2024 04:25
@terrymanu terrymanu merged commit 76a3ee7 into apache:master Jan 2, 2024
13 checks passed
@linghengqian linghengqian deleted the graalvm-javaagent branch January 2, 2024 05:45
@linghengqian linghengqian added this to the 5.4.2 milestone Jan 2, 2024
ziyilin
ziyilin reviewed Jan 5, 2024
View reviewed changes
docs/document/content/user-manual/shardingsphere-proxy/startup/graalvm-native-image.cn.md
@@ -133,28 +133,7 @@ services:
及其后继。如果你使用的不是 Linux，则无法对 GraalVM Native Image 进行 Debug，请关注尚未关闭的
https://github.com/oracle/graal/issues/5648 。

- 对于使用 `ShardingSphere Agent` 等 APM Java Agent 的情形， GraalVM 的 `native-image` 组件尚未完全支持在构建 Native
- 对于使用 `ShardingSphere Agent` 等 Java Agent 的情形， GraalVM 的 `native-image` 组件尚未完全支持在构建 Native
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR oracle/graal#8077 can support this scenario as well.

@linghengqian linghengqian mentioned this pull request Jan 15, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ziyilin ziyilin ziyilin left review comments

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
in: document
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@linghengqian @terrymanu @ziyilin