Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraalVM Reachability Metadata and corresponding nativeTest for Etcd integration #29755

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Jan 17, 2024

For #29052.

Changes proposed in this pull request:

  • Add GraalVM Reachability Metadata and corresponding nativeTest for Etcd integration.
  • Temporarily actively hosting GraalVM Reachability Metadata for io.netty:netty-transport-classes-epoll:4.1.99.Final.
  • Further remove unnecessary metadata JSON entries.
  • Change the port used by MySQL's nativeTest. On Windows 11 Professional with WSL2 enabled, 65107 is occupied, which is different from the behavior of Windows 11 Home and Student with WSL2 enabled. Dynamically defining YAML is one of the issues I'm tracking in profiles support global env value #29657.
  • Turn on quick build mode for the Maven Profile of nativeTestInShardingSphere. This helps development by sacrificing the peak performance of Native Image for faster build speeds. Refer to https://medium.com/graalvm/graalvm-22-1-developer-experience-improvements-apple-silicon-builds-and-more-b7ac9a0f6066 .
  • Set the buildArgs of -J-Xmx7g for the Maven Profile of nativeTestInShardingSphere to prevent Native Image build failures on low-performance devices with less than 10GB of available memory like Github Actions.
  • Renames graalvm.version to graal-sdk.version. This property actually refers to the Maven module of org.graalvm.sdk:graal-sdk:21.2.0, not to the GraalVM CE version used by the developer.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian force-pushed the etcd-eh branch 6 times, most recently from 3aef7b5 to 569acb8 Compare January 17, 2024 15:22
@linghengqian linghengqian marked this pull request as ready for review January 17, 2024 15:24
Comment on lines +54 to +59
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-grpc</artifactId>
<version>${vertx.version}</version>
<scope>test</scope>
</dependency>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrymanu terrymanu merged commit 5e97062 into apache:master Jan 18, 2024
140 checks passed
@linghengqian linghengqian deleted the etcd-eh branch January 18, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants