Add the release process of ShardingSphere Agent's Docker Image to the release guide #33377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
commented
Oct 23, 2024
Comment on lines
+587
to
+608
| 3.5 Log in to GitHub Packages Container Registry | ||
|
|
||
| ```shell | ||
| docker login ghcr.io/apache/shardingsphere | ||
| ``` | ||
|
|
||
| 3.6 Build and push ShardingSphere Agent Docker image | ||
|
|
||
| ```shell | ||
| cd ~/shardingsphere | ||
| git checkout ${RELEASE.VERSION} | ||
| ./mvnw -am -pl distribution/agent -Prelease,docker.buildx.push -T 1C -DskipTests clean package | ||
| ``` | ||
|
|
||
| 3.7 Confirm the successful release | ||
|
|
||
| Check [GitHub Packages](https://github.com/apache/shardingsphere/pkgs/container/shardingsphere-agent) for released images, and make sure that the image supports both `linux/amd64` and `linux/arm64`. | ||
|
|
||
| ```shell | ||
| docker logout | ||
| ``` | ||
|
|
There was a problem hiding this comment.
- CC @taojintianxia . Is this enough to resolve the original issue Push the Docker Image of ShardingSphere Agent 5.5.2+ to Github Packages #33350 ? I'm not sure every release manager's github account has the rights to execute
docker login ghcr.io/apache/shardingsphere. But asking ASF Infra to assist in registering a github account doesn't seem realistic.
The problem is that the
personal access token (classic)I generated from https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry does not have permission to manipulate the ASF namespace. And I'm not sure who has this authority, all PMCs? Some ASF members?
linghengqian
force-pushed
the
release-agent
branch
from
068be13 to
7c295db
Compare
terrymanu
approved these changes
Oct 26, 2024
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33350 .
Changes proposed in this pull request:
oraclelinux:9-slimtocontainer-registry.oracle.com/os/oraclelinux:9-slim#33263. Even ASF is limited by Docker Hub's rate limiting policy, which is not conducive to unit testing.Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.