Added support for STRRIGHT alias in Doris (#31508) #33393
+35
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RIGHT is already implemented and supported by both MySQL and Doris - Added parsing suppor t for the `STRRIGHT` alias in Doris - Updated existing tests to reflect that `RIGHT` is also supported by Doris - Added STRRIGHT tests - Marked `// DORIS ADDED BEGIN|END` Doris-specific changes - Added as a `regularFunctionName` which is where `RIGHT` is
danigiri
changed the title
|
I will look at the test results again as 76b9007 was supposed to fix the failing test |
also removed MySQL as target for the alias
|
Looks like on the most current code Waiting for that full rebuild to finish and issuing a fresh commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing with Doris parsing support.
In this case
RIGHTis already implemented and supported by both MySQL and Doris so ammended the tests and addedSTRRIGHTsupport which is an alias in Doris.Continues to address #31508.
Changes proposed in this pull request:
STRRIGHTalias in DorisRIGHTis also supported by DorisSTRRIGHT-specific test// DORIS ADDED BEGIN|ENDDoris-specific changes, and fixed a typo in existing oneregularFunctionNamewhich is whereRIGHTis so no java changes should be neededSELECT STRRIGHT('foobarbar',4)in Doris 3.0.2 correctlyNext
finish compiling Doris v3 to test the query codemy local machine is not powerful enoughBefore committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.mvn spotless:apply -Pcheckmvn test -Dit.test=InternalDorisParserITinshardingsphere/parser/sql/dialect/doris(need to specify it.test)SELECT STRRIGHT('foobarbar',4)