Adds documentation for ClickHouse support #33779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
force-pushed
the
clickhouse-graalvm
branch
from
d2cfa11 to
8664054
Compare
linghengqian
force-pushed
the
clickhouse-graalvm
branch
from
8664054 to
0842464
Compare
linghengqian
commented
Nov 24, 2024
Comment on lines
+178
to
+182
| Because `com.clickhouse.jdbc.ClickHouseConnection#prepareStatement(String, int)` of `com.clickhouse:clickhouse-jdbc:0.6.3:http` | ||
| Maven module intentionally throws an exception when `autoGeneratedKeys` is `java.sql.Statement.RETURN_GENERATED_KEYS`, | ||
| to prevent ShardingSphere from proxying `com.clickhouse.jdbc.internal.ClickHouseConnectionImpl` normally, | ||
| therefore, if users need to obtain the Key generated by ShardingSphere from the JDBC business code, | ||
| they need to set `autoGeneratedKeys` to `java.sql.Statement.NO_GENERATED_KEYS`. |
There was a problem hiding this comment.
- I opened
ClickHouseConnection#prepareStatement(String, int)should not throw an exception whenStatement.RETURN_GENERATED_KEYSis recognized ClickHouse/clickhouse-java#1968 for this. Related issues already exist from a few years ago.
strongduanmu
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
org.testcontainers.jdbc.ContainerDatabaseDriver#killContainers()in the testcontainers document. Some downstream projects have enabled the parallel execution feature of unit tests in Junit5, but this feature is basically useless for testcontainers-java because the concurrency capability of the Client/Server architecture of Docker Engine may not be that strong.org.apache.commons:commons-textdependency used by shardingsphere jdbc started to conflict with https://github.com/apache/hive/blob/rel/release-4.0.1/jdbc/pom.xml .Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.