Bump the minimum Seata Client version for Seata AT integration to 2.2.0 #33872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
added
feature: transaction
type: dependencies
linghengqian
force-pushed
the
seata-v220
branch
3 times, most recently
from
b207cf2 to
83caaa7
Compare
linghengqian
force-pushed
the
seata-v220
branch
from
83caaa7 to
8f9be44
Compare
linghengqian
commented
Dec 2, 2024
Comment on lines
+23
to
+28
| # TODO This is not a reasonable configuration, just affected by https://github.com/apache/incubator-seata/pull/6661. Pending investigation. | ||
| client { | ||
| rm { | ||
| tableMetaCheckEnable = "false" | ||
| } | ||
| } |
There was a problem hiding this comment.
- I have opened The default value of the property
client.rm.tableMetaCheckEnableshould be changed tofalseto align with the behavior of Seata Client 2.1.0 and earlier incubator-seata#7042 . I don't believe this is sensible default behavior for Seata Client.
strongduanmu
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #29052.
Changes proposed in this pull request:
org.apache.seata.core.rpc.netty.v1.ProtocolV1Decoderandorg.apache.seata.core.rpc.netty.v1.ProtocolV1Encoderhave been renamed in feature: multi-version seata protocol support incubator-seata#6226client.rm.tableMetaCheckEnableis nowtrue, which completely breaks the logic of creating and destroying Seata Client in unit tests. This needs to be investigated on the Seata side. See Seata Client should allow dynamic monitoring of changes inservice.default.grouplistincubator-seata#7039 .Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.