Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: tcp-proxy front design and develop #289

Merged
merged 5 commits into from
Jun 24, 2023
Merged

feature: tcp-proxy front design and develop #289

merged 5 commits into from
Jun 24, 2023

Conversation

eurecalulu
Copy link
Contributor

@eurecalulu eurecalulu commented Jun 22, 2023 •
edited
Loading

card
  • discovery configuration：
configuration
  • add proxy-selector：
add
  • modify proxy-selector with editableTable
modify

li-keguo
li-keguo approved these changes Jun 24, 2023
View reviewed changes
src/utils/utils.js
@@ -184,3 +184,15 @@ export function guid() {
}
return `${S4() + S4()}-${S4()}-${S4()}-${S4()}-${S4()}${S4()}${S4()}`;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can use moment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can use moment

Thanks for your advice! I submitted a new pr and refactored this function in it.

@li-keguo li-keguo merged commit f2c574c into apache:master Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-keguo li-keguo li-keguo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eurecalulu @li-keguo