Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically refresh global data after editing plug-in status #323

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

kerwin612
Copy link
Member

Before:

Edit the plug-status on the /config/plugin page, and then switch to the /plug/XXX page. The status is not updated, and the page needs to be refreshed manually

image

After:

Automatically refresh global data after editing status on the /config/plugin page

image

@kerwin612 kerwin612 changed the title Update index.js Automatically refresh global data after editing plug-in status Aug 20, 2023
@li-keguo
Copy link
Member

To be determined

@li-keguo
Copy link
Member

about #304

@li-keguo
Copy link
Member

li-keguo commented Sep 10, 2023

hi I'm sorry, I replied a bit late, I tried to verify this fix, but it didn't work as expected.

There may be two points of repair implementation:

1.The plugin/xxx page gets the plugin details from the background when it loads, not from the menu (memory).

The plug-in pair operation on the page is based on the obtained data

2.cnfig/plugin page modification plugins require menu refresh (memory)

@kerwin612
Copy link
Member Author

hi I'm sorry, I replied a bit late, I tried to verify this fix, but it didn't work as expected.

There may be two points of repair implementation:

1.The plugin/xxx page gets the plugin details from the background when it loads, not from the menu (memory).

The plug-in pair operation on the page is based on the obtained data

2.cnfig/plugin page modification plugins require menu refresh (memory)

Unified the update logic of the plug-ins:

  1. Unified the update entrance, distinguished between updating the status only and updating data.
  2. The plugin update will unify pulling data from the API to ensure editing based on the latest data.
  3. Unified the logic of updating global plugin cache information, and all update plugin locations will call uniformly.

@li-keguo
Copy link
Member

It was amazing.

Another point is that when we modify the data in config/plugin, we may also need to refresh the menu list, which is better

image image

@li-keguo li-keguo merged commit 1aa6a24 into apache:master Sep 11, 2023
5 checks passed
@kerwin612 kerwin612 deleted the patch-3 branch September 12, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants