#24

[nuo-promise]

international complete

[dengliming]

Looks great to me! Thanks.

[dengliming]

个人建议这个地方可以下次优化下，看看能否菜单数据里面加多个属性标识不用通过path判断，通过标识去拼接一些前缀去获取国际化配置好点，这样不用每加一个菜单这里加多个判断

[nuo-promise]

好点子,下一版本 优化掉,这样通过属性值 来选择 对应语言 dengliming <notifications@github.com> 于2020年12月2日周三 下午5:31写道：

…

***@***.**** approved this pull request. Looks great to me! Thanks. ------------------------------ In src/components/SiderMenu/SiderMenu.js <#39 (comment)>: > + if (this.props.menuData.length > 0) { + for ( let i = 0 ; i < this.props.menuData.length; i+=1) { + if(this.props.menuData[i].path === '/plug') { + this.props.menuData[i].name = getIntlContent("SOUL.MENU.PLUGIN.LIST"); + } else if(this.props.menuData[i].path === '/system'){ + this.props.menuData[i].name = getIntlContent("SOUL.MENU.SYSTEM.MANAGMENT"); + if(this.props.menuData[i].children.length > 0) { + for(let j = 0; j < this.props.menuData[i].children.length; j+=1) { + const childrenPath = this.props.menuData[i].children[j].path; + if(childrenPath === '/system/manage') { + this.props.menuData[i].children[j].name = getIntlContent("SOUL.MENU.SYSTEM.MANAGMENT.USER"); + } else if(childrenPath === '/system/plugin') { + this.props.menuData[i].children[j].name = getIntlContent("SOUL.MENU.SYSTEM.MANAGMENT.PLUGIN"); + } else if(childrenPath === '/system/auth') { + this.props.menuData[i].children[j].name = getIntlContent("SOUL.MENU.SYSTEM.MANAGMENT.AUTHEN"); + } else if(childrenPath === '/system/metadata') { + this.props.menuData[i].children[j].name = getIntlContent("SOUL.MENU.SYSTEM.MANAGMENT.METADATA"); + } else if(childrenPath === '/system/dict') { + this.props.menuData[i].children[j].name = getIntlContent("SOUL.MENU.SYSTEM.MANAGMENT.DICTIONARY"); + } + } + } + } + } + } + } 个人建议这个地方可以下次优化下，看看能否菜单数据里面加多个属性标识不用通过path判断，通过标识去拼接一些前缀去获取国际化配置好点，这样不用每加一个菜单这里加多个判断 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#39 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALAFSKVQXEQTZ43AJDJAZRTSSYCOVANCNFSM4UKALXFA> .