fix stop.sh execute failed in macos (#3187) #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
�optimize start.sh ,support different jdk configure JAVA_OPTS parameter
fix start.bat [shenyu-bootstrap-dist missing agent parameter in start.bat script (Issue apache#2814)]
This reverts commit cf002c9.
Codecov Report
@@ Coverage Diff @@
## master #3188 +/- ##
============================================
+ Coverage 57.47% 57.52% +0.05%
- Complexity 4526 4528 +2
============================================
Files 730 730
Lines 20818 20818
Branches 1915 1915
============================================
+ Hits 11965 11976 +11
+ Misses 7803 7792 -11
Partials 1050 1050
Continue to review full report at Codecov.
|
yu199195
reviewed
Apr 3, 2022
| @@ -22,7 +22,7 @@ cd `dirname $0` | |||
| cd .. | |||
| DEPLOY_DIR=`pwd` | |||
|
|
|||
| PIDS=`ps -eo pid,cmd |grep -v tail|grep -v grep|grep "$DEPLOY_DIR"|awk '{print $1}'` | |||
| PIDS=`ps ax |grep -v tail|grep -v grep|grep "$DEPLOY_DIR"|awk '{print $1}'` | |||
There was a problem hiding this comment.
Yes, I already verified it in ubuntu and centos.
yu199195
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix stop.sh exxcute failed in macos(#3187)
Make sure that:
mvn clean install -Dmaven.javadoc.skip=true.