Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:refactor]Split the document field of the apidoc detail interface,and add fields such as requestHeaders and responseParameters. #4865

Merged
merged 100 commits into from
Jul 18, 2023

Conversation

lianjunwei
Copy link
Contributor

@lianjunwei lianjunwei commented Jul 17, 2023

1.To simplify front-end development, the "document" field of the detailed interface of apidoc is disassembled. Added fields such as requestHeaders and responseParameters.

2.#4848 , and fix bug: #4779
Front end pr, see: apache/shenyu-dashboard#294

3.Merge order:
first, #4849 , then ,#4865 (Reason: 4865 is based on a 4849 pull branch.)

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

lianjunwei and others added 30 commits June 9, 2022 01:26
yes
 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
# Conflicts:
#	shenyu-admin/src/main/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParser.java
ok# 以 '#' 开始的行将被忽略,而空的提交说明将终止提交。
… incorrect when micro service parameter uses "@ApiModelProperty".
…c function of the gateway management system.
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Merging #4865 (431d6e6) into master (327bf65) will increase coverage by 0.18%.
The diff coverage is 90.90%.

@@             Coverage Diff              @@
##             master    #4865      +/-   ##
============================================
+ Coverage     64.29%   64.47%   +0.18%     
- Complexity     8195     8224      +29     
============================================
  Files          1161     1161              
  Lines         34134    34153      +19     
  Branches       3060     3061       +1     
============================================
+ Hits          21946    22020      +74     
+ Misses        10445    10379      -66     
- Partials       1743     1754      +11     
Impacted Files Coverage Δ
...ache/shenyu/admin/service/impl/ApiServiceImpl.java 27.27% <80.00%> (+3.00%) ⬆️
...n/java/org/apache/shenyu/admin/model/vo/ApiVO.java 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

lianjunwei and others added 3 commits July 18, 2023 13:27
# Conflicts:
#	shenyu-admin/src/test/java/org/apache/shenyu/admin/service/manager/impl/SwaggerDocParserTest.java
@lianjunwei lianjunwei changed the title [ISSUE #4848]Disassemble the "document" field of the detail interface of apidoc and add fields such as requestHeaders and responseParameters. [ISSUE #4848]Split the document field of the apidoc detail interface,and add fields such as requestHeaders and responseParameters. Jul 18, 2023
@lianjunwei lianjunwei changed the title [ISSUE #4848]Split the document field of the apidoc detail interface,and add fields such as requestHeaders and responseParameters. [type:refactor]Split the document field of the apidoc detail interface,and add fields such as requestHeaders and responseParameters. Jul 18, 2023
@yu199195 yu199195 added this to the 2.6.0 milestone Jul 18, 2023
@yu199195 yu199195 merged commit 62629e5 into apache:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants