Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type:fix] fix plugin can not load resource path file #5372

Merged
merged 12 commits into from
Dec 21, 2023

Conversation

misaya295
Copy link
Contributor

@misaya295 misaya295 commented Dec 20, 2023

and pr apache/shenyu-dashboard#383.

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d93d6b7) 61.56% compared to head (6100edf) 61.56%.
Report is 1 commits behind head on master.

Files Patch % Lines
.../org/apache/shenyu/web/loader/PluginJarParser.java 0.00% 15 Missing ⚠️
...che/shenyu/web/loader/ShenyuPluginClassLoader.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5372   +/-   ##
=========================================
  Coverage     61.56%   61.56%           
- Complexity     8519     8522    +3     
=========================================
  Files          1236     1236           
  Lines         37296    37313   +17     
  Branches       3591     3593    +2     
=========================================
+ Hits          22961    22973   +12     
- Misses        12253    12257    +4     
- Partials       2082     2083    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moremind moremind added this to the 2.6.1 milestone Dec 21, 2023
@moremind moremind added the bootstrap bootstrap label Dec 21, 2023
@moremind moremind merged commit b1f0bad into apache:master Dec 21, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap bootstrap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants