Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[type:feat] add shenyu gateway namespace #5671

Merged
merged 4 commits into from
Sep 25, 2024
Merged

[type:feat] add shenyu gateway namespace #5671

merged 4 commits into from
Sep 25, 2024

Conversation

moremind
Copy link
Member

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@moremind moremind added this to the 2.7.0 milestone Sep 25, 2024
Aias00
Aias00 previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Aias00 Aias00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VampireAchao
VampireAchao previously approved these changes Sep 25, 2024
View reviewed changes
@moremind moremind dismissed stale reviews from VampireAchao and Aias00 via 3b175c9 September 25, 2024 13:43
Aias00
Aias00 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Aias00 Aias00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moremind moremind merged commit 26e590a into apache:master Sep 25, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aias00 Aias00 Aias00 approved these changes

@VampireAchao VampireAchao VampireAchao left review comments

Assignees
No one assigned
Labels
namespace
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@moremind @Aias00 @VampireAchao