[type:refactor]Decouple apidoc module from rule and selector modules #5685
Conversation
478320
force-pushed
the
feat_decouple_api_rule_select
branch
from
0f4a8fd to
7f98cd7
Compare
| @@ -110,6 +109,7 @@ public String createOrUpdate(final ApiDTO apiDTO) { | |||
| * @return update message | |||
| */ | |||
| private String update(final ApiDTO apiDTO) { | |||
| //cdbuild apiDO | |||
There was a problem hiding this comment.
Hello, my previous submission failed to check the instability of ci. I hope I can re-trigger ci through some modifications. If these modifications cause bad effects, I will delete them
| @@ -126,11 +126,6 @@ private String update(final ApiDTO apiDTO) { | |||
| tagRelationMapper.deleteByApiId(apiDO.getId()); | |||
| tagRelationMapper.batchInsert(tags); | |||
| } | |||
| if (ApiStateEnum.PUBLISHED.getState() == apiDO.getState()) { | |||
There was a problem hiding this comment.
When creating apidoc, this part determines whether the document is in the published state, and if the document is in the published state, the selector is registered, etc. If it is in the offline state, the corresponding selector content is deleted, which will lead to the coupling of apidoc and selector. Deleting this part can release their coupling. The removal of this feature will have the following effects, the document publication and logout will only be displayed as a status without additional functions, the document logout and online need to manually add and delete selectors and other content, for the creation of api documents, Users using @RequestMapping and other annotations and users using swagger will automatically create selectors and other content through annotations, which will not affect the convenience brought by automation. To add api documents in the visual interface, you need to manually create corresponding selector, rule, and Metadata. For the offline api document, all users need to manually delete the corresponding selector, rule, and Metadata
…8320/shenyu into feat_decouple_api_rule_select Merge remote changes into local branch
decouple apidoc module from rule and selector modules, link #5623
Make sure that: