[ISSUE #5851] Sandbox API debugging, the target API method is not POST, and the response format is JSON. The API returns an exception. #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get method is not a POST request.
yu199195
reviewed
Dec 20, 2024
| * @return Response | ||
| * @throws IOException IOException | ||
| */ | ||
| public Response requestJson(final String url, final String json, | ||
| final Map<String, String> header) throws IOException { | ||
| final Map<String, String> header, HTTPMethod method) throws IOException { |
There was a problem hiding this comment.
HttpUtils#requestJson,This method is currently invoked in only one place.
The call stack of this method is as follows and the source code location..
org.apache.shenyu.admin.controller.SandboxController#proxyGateway. Line 52 - 55
org.apache.shenyu.admin.service.impl.SandboxServiceImpl#requestProxyGateway. Line 79 - 110
org.apache.shenyu.admin.utils.HttpUtils#requestCall. Line 303 - 308
org.apache.shenyu.admin.utils.HttpUtils#requestJson. Line 226 - 231
There was a problem hiding this comment.
Applied Checkstyle to HttpUtils file
|
SKonst
***@***.***
HttpUtils#requestJson,This method is currently invoked in only one place.
The call stack of this method is as follows and the source code location..
org.apache.shenyu.admin.controller.SandboxController#proxyGateway. Line 52 - 55
org.apache.shenyu.admin.service.impl.SandboxServiceImpl#requestProxyGateway. Line 79 - 110
org.apache.shenyu.admin.utils#requestCall. Line 303 - 308
org.apache.shenyu.admin.utils#requestJson. Line 226 - 231
…------------------ 原始邮件 ------------------
发件人: "apache/shenyu" ***@***.***>;
发送时间: 2024年12月20日(星期五) 上午10:34
***@***.***>;
***@***.******@***.***>;
主题: Re: [apache/shenyu] [ISSUE #5851] Sandbox API debugging, the target API method is not POST, and the response format is JSON. The API returns an exception. (PR #5852)
@yu199195 commented on this pull request.
In shenyu-admin/src/main/java/org/apache/shenyu/admin/utils/HttpUtils.java:
> * @return Response * @throws IOException IOException */ public Response requestJson(final String url, final String json, - final Map<String, String> header) throws IOException { + final Map<String, String> header, HTTPMethod method) throws IOException {
where is call this funcation？
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
yu199195
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…get method is not a POST request.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.