Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHIRO-551] Implement toString() for DelegatingSubject.java. #220

Merged
merged 1 commit into from
Jul 5, 2020
Merged

[SHIRO-551] Implement toString() for DelegatingSubject.java. #220

merged 1 commit into from
Jul 5, 2020

Conversation

bmarwell
Copy link
Contributor

@bmarwell bmarwell commented May 1, 2020

Fixes SHIRO-551.

I used StringJoiner instead of StringUtils.ToString, because the dependency to StringUtils is probably not needed anymore since Java 8.

@fpapon fpapon self-requested a review July 4, 2020 20:53
fpapon
fpapon requested changes Jul 4, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmhm can you fix the conflicts?

@bmarwell bmarwell requested a review from fpapon July 5, 2020 12:11
fpapon
fpapon approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@fpapon fpapon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpapon fpapon merged commit 8e3042f into apache:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpapon fpapon fpapon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmarwell @fpapon