[SHIRO-825] Fixes "IllegalArgumentException: There is no configured chain under the name/key"

[zAlbee]

Fixes https://issues.apache.org/jira/browse/SHIRO-825: Trailing slash in URI results in "IllegalArgumentException: There is no configured chain under the name/key"

When the request URI has a trailing slash, but the pattern does not have a trailing slash (or vice versa), it is still supposed to match. However, when they don't match exactly, we enter the else branch where the call to filterChainManager.proxy() has the incorrect parameter! (When they match exactly, the call to filterChainManager.proxy() has the correct parameter -- see line 114).

This seems to be a copy/paste error introduced by commit ab1ea4a#diff-a724e4e5fde47ea6cc29803d5a4581a299b74f09d4ec5ce047e7d3e056116815R129

In Shiro 1.7.0, it didn't have this duplicate code, and it was working correctly.

---

Following this checklist to help us incorporate your contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [SHIRO-XXX] - Fixes bug in SessionManager,
  where you replace SHIRO-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.

Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
In this case, just format the pull request title like (DOC) - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[bdemers]

Thanks @zAlbee!

We need a test case for this, I can add it, but I have a few follow up questions I'll post in SHIRO-825

[bdemers]

Test added :)

We need to backport this fix to 1.x, once this gets another set of eyes, I can backport it

[zAlbee]

I verified that this test passes in Shiro 1.7.0 and fails in 1.7.1 (without the fix). Thanks!

[bmarwell]

LGTM – THANKS! :)

[zAlbee]

Is there anything else I need to do to get this merged? (I noticed some failing checks). We saw that 1.7.1 fixed some vulnerabilities and would like to upgrade to a fixed version of that.

[bmarwell]

Is there anything else I need to do to get this merged?

Yes:

We need to backport this fix to 1.x, once this gets another set of eyes, I can backport it

@bdemers I can work on a backport next week. If you like, you can go ahead and merge it.