Skip to content

Commit

Permalink
Fix the record list query does not support new OAP versions (#197)
Browse files Browse the repository at this point in the history
  • Loading branch information
mrproliu authored Nov 29, 2023
1 parent 5d0a37c commit d4f774f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ Release Notes.
------------------

### Features

### Bug Fixes

* Fix the record list query does not support new OAP versions (with major version number > 9).

## What's Changed

* Add the sub-command `menu get` for get the ui menu items by @mrproliu in https://github.com/apache/skywalking-cli/pull/187
Expand Down
2 changes: 1 addition & 1 deletion internal/commands/metrics/aggregation/sampled-record.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ $ swctl metrics sampled-record --name top_n_database_statement 5
}

// since 9.3.0, use new record query API
if major >= 9 && minor >= 3 {
if (major == 9 && minor >= 3) || major > 9 {
condition, duration, err1 := buildReadRecordsCondition(ctx)
if err1 != nil {
return err1
Expand Down

0 comments on commit d4f774f

Please sign in to comment.