Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting start end with relative time #128

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

kezhenxu94
Copy link
Member

@wankai123 can you please verify?

@kezhenxu94 kezhenxu94 added the feature this pull request provides new feature label Oct 26, 2021
@kezhenxu94 kezhenxu94 added this to the 0.10.0 milestone Oct 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #128 (9350b6a) into master (48338d3) will decrease coverage by 0.52%.
The diff coverage is 15.78%.

❗ Current head 9350b6a differs from pull request most recent head 6503ed8. Consider uploading reports for the commit 6503ed8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   28.00%   27.47%   -0.53%     
==========================================
  Files          20       20              
  Lines         400      404       +4     
==========================================
- Hits          112      111       -1     
- Misses        280      286       +6     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
internal/commands/interceptor/duration.go 43.85% <15.78%> (-5.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48338d3...6503ed8. Read the comment docs.

Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified

@wankai123 wankai123 merged commit 45a5f98 into master Oct 26, 2021
@wu-sheng wu-sheng deleted the duration/relative branch October 26, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature this pull request provides new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants