Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt OAP V9 query protocol #133

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Jan 6, 2022

Resolve apache/skywalking#8370

  1. Add Two commands: layer list and service layer.
  2. Add layer attribute in metadata query v2.
  3. Adopt v9 or older OAP query.

@mrproliu mrproliu added the enhancement New feature or request label Jan 6, 2022
@mrproliu mrproliu added this to the 0.10.0 milestone Jan 6, 2022
@mrproliu mrproliu requested a review from wu-sheng January 6, 2022 07:38
@codecov-commenter
Copy link

Codecov Report

Merging #133 (14192c5) into master (460b194) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   27.47%   27.47%           
=======================================
  Files          20       20           
  Lines         404      404           
=======================================
  Hits          111      111           
  Misses        286      286           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70241d4...14192c5. Read the comment docs.

@wu-sheng
Copy link
Member

wu-sheng commented Jan 6, 2022

Lint fails, please fix.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @wankai123 Please submit an issue to update the e2e tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] [CLI] Support metadata query v2
3 participants