Add the Process metadata query command #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrproliu
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=======================================
Coverage 27.47% 27.47%
=======================================
Files 20 20
Lines 404 404
=======================================
Hits 111 111
Misses 286 286
Partials 7 7 Continue to review full report at Codecov.
|
kezhenxu94
reviewed
Mar 10, 2022
internal/commands/process/list.go
Outdated
Comment on lines
48
to
49
| 4. List all processes by instance id "cHJvdmlkZXI=.1_cHJvdmlkZXIx": | ||
| $ swctl process ls --service-id cHJvdmlkZXI=.1_cHJvdmlkZXIx`, |
There was a problem hiding this comment.
the description by instance id doesn't match the command ls --service-id
There was a problem hiding this comment.
update the command line argument name.
kezhenxu94
reviewed
Mar 10, 2022
kezhenxu94
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve apache/skywalking#8650
command-line screenshot:
