Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove total field in trace list and logs list commands #152

Merged
merged 2 commits into from
May 18, 2022
Merged

Remove total field in trace list and logs list commands #152

merged 2 commits into from
May 18, 2022

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu added the enhancement New feature or request label May 18, 2022
@mrproliu mrproliu added this to the 0.11.0 milestone May 18, 2022
@mrproliu mrproliu requested review from wu-sheng and kezhenxu94 May 18, 2022 10:25
@kezhenxu94 kezhenxu94 requested a review from fgksgf May 18, 2022 10:33
@wu-sheng
Copy link
Member

Is CLI having next page condition?

@mrproliu
Copy link
Contributor Author

Is CLI having next page condition?

Yes, if trace list shows graph, then it has a pagination plugin.
Right now, I just do the next page, and the CLI will print "no data".

@wu-sheng wu-sheng merged commit 48238c6 into apache:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@kezhenxu94 kezhenxu94 Awaiting requested review from kezhenxu94

@fgksgf fgksgf Awaiting requested review from fgksgf

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mrproliu @wu-sheng