Adapt the new record query API for sub-command metrics sampled-record
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think metrics sampled-record should be an alias, and we need a new record command to map for the new protocol? https://skywalking.apache.org/docs/main/next/en/protocols/query-protocol/#record |
|
Sure, I could create a new command: |
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 26.20% 26.20%
=======================================
Files 22 22
Lines 458 458
=======================================
Hits 120 120
Misses 328 328
Partials 10 10 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Should be add 9.3.0 requirement for next CLI release? |
|
Updated. |
wu-sheng
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adapt the new record query API: apache/skywalking-query-protocol#100
After this PR has been merged, I will submit other PR in the main repo.