Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support continuous profiling related sub-commands #173

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Mar 2, 2023

  1. profiling continuous set: set the continuous profiling policy to a service.
  2. profiling continuous list: query the continuous profiling policy in a service.
  3. profiling ebpf list: add the triggerType parameter for the continuous profiling task query.
  4. metrics: adopt the "scope" parameter in the metrics-related sub-command.

@mrproliu mrproliu added the enhancement New feature or request label Mar 2, 2023
@mrproliu mrproliu added this to the 0.12.0 milestone Mar 2, 2023
@mrproliu mrproliu requested a review from wu-sheng March 2, 2023 14:51
@wu-sheng
Copy link
Member

wu-sheng commented Mar 2, 2023

Could you share what is the command(s) added here?

@mrproliu
Copy link
Contributor Author

mrproliu commented Mar 2, 2023

Yes, I have descript the commands in the PR description.

@wu-sheng
Copy link
Member

wu-sheng commented Mar 2, 2023

metrics: adopt the "range" parameter in the metrics-related sub-command.

What do you mean range? I don't remember we changed metrics query GraphQL.

@mrproliu
Copy link
Contributor Author

mrproliu commented Mar 2, 2023

Oh, update to the "scope", I typed the wrong word.

@wu-sheng wu-sheng merged commit 838e222 into apache:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants