Support SpanAttachedEvent #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanahmily
previously approved these changes
Oct 13, 2022
wu-sheng
commented
Oct 13, 2022
mrproliu
approved these changes
Oct 13, 2022
This was referenced Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @apache/skywalking-committers
This is a new extension and the first one after Trace Data Protocol v3. So I marked this as v3.1, the main document would be updated once this is really implemented.
Case Scenario
When an RPC is being traced by the in-process language agent, a span would be reported by the client-side agent.
And the rover would be aware of this RPC due to the existing tracing header.
Then, the rover agent collects extra information from the OS level to provide assistance information to diagnose network performance.
Who is going to implement this
The Rover(ebpf) agent would implement this. This relies on the rover agent having the capability to decode HTTP(at least) header and body on the fly.