Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fields into access log protocol #91

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Jan 4, 2024

  1. Add a cluster field to assist in building Kubernetes service names on the backend.
  2. Add a protocol field to declare the protocol in the connection.

@mrproliu mrproliu requested a review from wu-sheng January 4, 2024 13:30
Comment on lines 334 to 337
enum AccessLogProtocolType {
Unknown = 0;
HTTP = 1;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No TCP? Is this a L7 protocol?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the Unknown It should be TCP. Or should I update the Unknown to the TCP?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep that clear. If one day, there is something like Kafka, UDP, UNKNOWN is confusing.

@wu-sheng wu-sheng merged commit 46d5558 into apache:master Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants