fix: Fish completion script corrupted by INFO log message#259
Merged
kezhenxu94 merged 2 commits intoapache:mainfrom Feb 11, 2026
Merged
fix: Fish completion script corrupted by INFO log message#259kezhenxu94 merged 2 commits intoapache:mainfrom
kezhenxu94 merged 2 commits intoapache:mainfrom
Conversation
kezhenxu94
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fish completion script has an
INFOlog message at the start of the file, which breaks the shell script syntax:INFO Loading configuration from file: .licenserc.yaml # fish completion for license-eye...This causes fish to error:
'end' outside of a blockwhen sourcing the completion file. Example:Root Cause
The
PersistentPreRunEhook incommands/root.goloads the config file, which logs an INFO message before the completion script is generated. When runninglicense-eye completion fish, the config loading happens before outputting the completion script.The issue manifests in two ways:
__completecommandFix
Skip config loading in
PersistentPreRunEfor both:completionparent command__completecommand used internally by cobra