Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some program compatibility issues in Windows #44

Merged
merged 1 commit into from
Jul 16, 2021
Merged

fix some program compatibility issues in Windows #44

merged 1 commit into from
Jul 16, 2021

Conversation

zooltd
Copy link
Contributor

@zooltd zooltd commented Jul 16, 2021

The embeded file system embed.FS only takes the forward slash (/) as the path separator. However, the operating system path separator in Windows is the backward slash (\). We need to normalize the file path separator each time we use embed.FS.

@kezhenxu94 kezhenxu94 added the enhancement New feature or request label Jul 16, 2021
@kezhenxu94 kezhenxu94 added this to the 0.2.0 milestone Jul 16, 2021
kezhenxu94
kezhenxu94 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! We might also consider adding Windows to the CI test matrices.

@kezhenxu94 kezhenxu94 merged commit 126ce2b into apache:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zooltd @kezhenxu94