fix: limit the bytes of redis args #153
Conversation
plugins/go-redisv9/hook.go
Outdated
| @@ -187,3 +187,13 @@ func getKey(args []interface{}) string { | |||
| } | |||
| return key | |||
| } | |||
|
|
|||
| const maxArgsLength = 1024 | |||
There was a problem hiding this comment.
Hard code the limitation? I don't think this is a good practice.
Please follow this pattern, https://github.com/apache/skywalking-go/blob/main/tools/go-agent/config/agent.default.yaml
There was a problem hiding this comment.
done, please cr again 😁
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
rfyiamcool
force-pushed
the
fix/limit_bytes_redis_args
branch
from
d1f15f3 to
80e9655
Compare
| @@ -4,5 +4,6 @@ | |||
| |--------------------------------|-------------------------------------------------------|---------------|----------------------------------------------------------------| | |||
| | http.server_collect_parameters | SW_AGENT_PLUGIN_CONFIG_HTTP_SERVER_COLLECT_PARAMETERS | false | Collect the parameters of the HTTP request on the server side. | | |||
| | mongo.collect_statement | SW_AGENT_PLUGIN_CONFIG_MONGO_COLLECT_STATEMENT | false | Collect the statement of the MongoDB request. | | |||
| | redis.max_args_bytes | SW_AGENT_PLUGIN_CONFIG_REDIS_MAX_ARGS_BYTES | 1024 | Limit the bytes size of redis args request. | | |||
There was a problem hiding this comment.
Please align the order here and config file.
This should be after sql config.
There was a problem hiding this comment.
done. 😅
sorry, because of the display problem of the ide, I didn't notice that the table was not aligned.
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
|
Could you add this feature into the CHANGES.md? |
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
done. 😁 |
|
Please fix the CI. |
I don't know how to fix this problem. 😅 give me some Pointers. |
|
CI had logs, you should be able to read them, and CI is able to run locally. |
|
Did you test the codes you changed? It seems it doesn't work and runnable actually. https://github.com/apache/skywalking-go/actions/runs/7044082174/job/19171487594?pr=153 |
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
rfyiamcool
force-pushed
the
fix/limit_bytes_redis_args
branch
from
c916a1d to
63e4de5
Compare
summary
limit the bytes of redis args.