Optimize plugin selector logic. #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will check the codes later. |
wu-sheng
reviewed
Nov 30, 2023
...ffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/PluginCfg.java
Outdated
Show resolved
Hide resolved
…/apm/agent/core/plugin/PluginCfg.java Co-authored-by: 吴晟 Wu Sheng <wu.sheng@foxmail.com>
wu-sheng
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of PluginSelector
CHANGESlog.PluginCfgcallPluginSelector#selectevery plugin and every line in skywalking-plugin.def in load function, I move it toPluginCfg#getPluginClassList, then it just need call once.I tested in my local pc (8C 16G), it can save 200ms + boot time when I exclude 4 plugins by config
plugin.exclude_plugins.