-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method #658
Conversation
I want to double-check, this test has covered 3.2.18.RELEASE, so, only 3.2.0 had the bug, but 3.2.8 is OK? |
I can write a scenario with version |
The link I provided, it has tested 3.1.4.RELEASE, 3.2.18.RELEASE, 4.0.9.RELEASE, check this, https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/spring-3.1.x-scenario/support-version.list. What I want to confirm with you is, is this test covers your scenario if we add 3.2.0.xx into that? Or 3.2.18 is still having this bug just not covered by the test. |
|
@@ -15,3 +15,5 @@ | |||
# limitations under the License. | |||
|
|||
6.0.4 | |||
6.1.0 | |||
6.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, only this is using SpringBoot 3.2.0, which was failing before the fix, am I getting your idea correctly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I tracd my own springboot project in 3.2.0(Spring 6.1.1), and find SpringMVC node missing, but springboot project in 3.1.6(Spring 6.0.14) works.
Fix NoSuchMethodError in mvc-annotation-commons&change deprecated method
Add a unit test to verify that the fix works.
current test scenarios(spring-4.3.x-scenario, spring-6.x-scenario) passed.
Explain briefly why the bug exists and how to fix it.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes [Bug] mvc-annotation-commons NoSuchMethodError ServerHttpRequest.getMethodValue() skywalking#11652.
Update the
CHANGES
log.