Support for tracing webflux-6.x and gateway-4.x #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Dec 20, 2023
test/plugin/scenarios/gateway-4.x-scenario/gateway-projectA-scenario/pom.xml
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Dec 20, 2023
| segments: | ||
| - segmentId: not null | ||
| spans: | ||
| - operationName: /provider/timeout/error |
There was a problem hiding this comment.
Is this timeout built intentionally?
There was a problem hiding this comment.
in order to check error case.
There was a problem hiding this comment.
My question is, are the codes causing the timeout on testing purpose?
There was a problem hiding this comment.
according to gateway3.x, in order to check request timeout case, so add the testcasse, issue
wu-sheng
reviewed
Dec 20, 2023
| segments: | ||
| - segmentId: not null | ||
| spans: | ||
| - operationName: /provider/timeout/error |
There was a problem hiding this comment.
Why is a timeout for entry? How an entry span timeout?
wu-sheng
reviewed
Dec 20, 2023
3 tasks
|
Could you confirm this #661 (comment)? If the codes don't seem to trigger error, we should not have them in the expected data. |
wu-sheng
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for spring-cloud-gateway 4.x
why:
spring-cloud-starter-gateway 4.0.0 depends on spring-boot-starter-webflux 3.0.0
spring-boot-starter-webflux 3.0.0 depends on spring-webflux 6.0.2
spring-webflux-5.x plugin can not trace the request
how:
add support for spring-webflux-6.x diff from 5.x by witnessmethod
upgrade spring-cloud-gateway to 4.x with spring-webflux-6.x diff from 3.x by witnessclass
Add an agent plugin to support spring-cloud-gateway 4.x
Add a test case for the new plugin, refer to the doc
Update the
CHANGESlog.