support to try to use request-id as trace-id when trace context absent #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhenxu94
reviewed
Apr 21, 2022
wu-sheng
reviewed
Apr 22, 2022
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| segmentItems: |
There was a problem hiding this comment.
Where could verify requestId in this e2e test? I think I miss it
There was a problem hiding this comment.
covered.
skywalking-nginx-lua/test/e2e/user/config.yaml
Lines 23 to 29 in 19eaae6
There was a problem hiding this comment.
I mean, we just would verify codes work, but can see whether request ID is used, right?
wu-sheng
approved these changes
Apr 22, 2022
|
Could you check showcase, whether new tracer would have trace ID changing to request ID? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.